Smoking was negatively associated with T2DM in Chinese men of normal body weight, but no significant association was found for men with overweight/obesity or women. In addition, smoking was positively associated with nonfatal stroke, especially in patients with T2DM. Further prospective studies are needed to examine the association between smoking, diabetes, and stroke in different ethnic groups.